Page 1 of 1

V14.3 beta5

Posted: Sun Apr 07, 2019 9:01 am
by Pierrot
New beta available with some important fixes!
  • Add two new options to select status and navigation bar light schemes (and dark icons)
  • Tap outside of folder to close it (with a setting, off by default for compatibility with existing setups)
  • Fix broken shortcuts when updating some apps
  • Fix blank space on devices with a notch in the display (Samsung S10, One Plus One, etc.), due to incorrect navigation bar size computation
If this version is stable enough, I'll release it as the next stable release.

ChangeLog: https://www.lightninglauncher.com/wordpress/change-log/

Re: V14.3 beta5

Posted: Sun Apr 07, 2019 7:18 pm
by dew
Thanks for this update :)

Regarding the "tap outside folder to close it" thing I have two findings:

- It was ON by default on my phone after the update! I did nothing to enable it and windows now close autopmatically.
(For me that's ok.)

- The "outside" gesture which auto-closes the window is consumed and only used for closing the window. It would be much better if you could just swipe, tap outside of the window and actually perform the intended action while still auto-closing the open window. The problem with not auto-closing was that I wanted to tap another app or swipe to another screen and the window remained open. Now it auto-closes but the intended action (tapping an icon, swiping to a differnt screen) is not performed as the gesture is consumed for closing the window and threfore the same gesture must be done twice in order to achieve the desired action. This is a little annoying.
I hope you can change it so that an "outside" gesture performs the action it would normally do on the "ouside" and still auto-closes all an open window as a wanted side-effect.

Thanks :) :) :)

Re: V14.3 beta5

Posted: Sun Apr 07, 2019 9:54 pm
by TrianguloY
If you just wanted to close the folders when opening another outside app you could just set the resumed event of the desktop to 'close all folders', and enable the 'close other folders'. Closing it when swiping is a bit more difficult but should be possible with the position changed event I think.

And you are right, the auto close is enabled by default on new and old folders! Oops.

The behaviour of 'consuming' the event to close the folders is expected I think...it is the behaviour on almost all the other launchers. I'll wait for what Pierre thinks but maybe what can be done is make the 'outside' of the folder darker to remark it.

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 5:55 am
by Pierrot
Argh... I set the flag to true for testing, and forgot to switch it back to false before to commit the change, my bad :-( I will revert it to false, I know some setups that specifically don't play nice with this.

I hesitated regarding the event consumption and tried both. I also prefer when the event is not consumed and trigger the action behind, but also it creates a border effect : when multiple folders are opened, they will all close at once.

Wait... Maybe this could be possible to handle this particular case... Do you think at any other situation like this?

@TrianguloY about the darker outside : that's something to explore! Also I'd like to try again to add some bluring.

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 6:45 am
by TrianguloY
Do you talk about:
A) A folder with the setting disabled is opened, then a folder with the setting enabled is opened, so clicking outside closes both (should only close the latest. Or
B) A folder with the setting enabled is opened, then from inside of that one a folder with the setting disabled is opened, so clicking outside should close both?

I think what should be done is 'traverse all folders in lifo order (latest opened is checked first) and close them until one with the setting enabled is found, then stop'.

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 7:57 am
by PrasadKaladi
Sorry, for me, it's not working. Force closes whenever I unlock the phone. I'm on OnePlus3T, Android v 8.0

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 8:29 am
by Pierrot
None of A or B :) I'm talking about:
C) When two or more folders are open, all with the setting enabled, tapping outside one will also close the others (because the event traverses all layers).

Yes, closing only the first folder is what should be done. I need to figure a way to do that.

@PrasadKaladi can you send the crash report, or is the Android dialog box not displayed ?

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 8:56 am
by PrasadKaladi
[mention]Pierrot[/mention] crash report sent.
Dialog box asking for Close LLX/Send Feedback is shown.

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 11:19 am
by dew
Pierrot wrote:
> None of A or B :) I'm talking about:
> C) When two or more folders are open, all with the setting enabled, tapping
> outside one will also close the others (because the event traverses all
> layers).
>
> Yes, closing only the first folder is what should be done. I need to figure
> a way to do that.
>
> @PrasadKaladi can you send the crash report, or is the
> Android dialog box not displayed ?


For me that's no issue because having multiple windows open at the same time rarely makes sense for me...
And nice to hear that you also prefer the event *not* to be consumed by windows closing. This makes it much more logical and understandable IMHO.

Re: V14.3 beta5

Posted: Mon Apr 08, 2019 11:26 am
by dew
Pierrot wrote:
> None of A or B :) I'm talking about:
> C) When two or more folders are open, all with the setting enabled, tapping
> outside one will also close the others (because the event traverses all
> layers).

I but if "traverses all layers" means that nesting is also affected i.e. bypassed it would be a problem. I mean when I open a folder A and in that folder I open another folder B and then tap on a separate element C outside of B but still inside of A - then closing A would be undesired!

So respecting the hiearchy level would be required. Simply closing all windows is no good idea.
But I assume the event should be consumed by C anyways?

Re: V14.3 beta5

Posted: Sat Apr 20, 2019 9:51 am
by Wern-YuenTan
with the latest beta, the previous bug preventing third party apps from creating shortcuts on the desktop is now back. it was fixed a few versions ago after it was reported, but seems to have reverted back

Re: V14.3 beta5

Posted: Mon Apr 29, 2019 9:29 am
by Pierrot
Sorry for the delay, I took some vacations and lost track of this thread.

@Wern-YuenTan: I could not reproduce this. Do you have a specific app example in mind?

Re: V14.3 beta5

Posted: Fri May 24, 2019 4:08 pm
by Wern-YuenTan
It's working for me now. Not sure what I did differently but a clean redesign of my template worked. Thanks and hope you had a good vacation!